dotnet/runtime

Remove unsafe code from number parsing

Open

#10,397 opened on May 29, 2018

View on GitHub
 (11 comments) (3 reactions) (0 assignees)C# (5,445 forks)batch import
Cost:Marea-System.Numericshelp wantedreduce-unsafe

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

There is heavy use of unsafe code in number.parsing.cs and calling code (eg at https://github.com/dotnet/runtime/blob/110282c71b3f7e1f91ea339953f4a0eba362a62c/src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs#L255). This could be rewritten with ReadOnlySpan<char> to eliminate the char * resulting in safer code that is also easier to read.

Relates to https://github.com/dotnet/coreclr/pull/17808

Contributor guide

Research direction
Rewrite the unsafe code in Number.Parsing.cs using ReadOnlySpan<char> instead of char*. Follow the pattern from the referenced PR (dotnet/coreclr#17808) and ensure all callers are updated accordingly.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70