dotnet/roslyn

Fix cascading diagnostics when using invalid crypto options with PublicSign

Open

#9,198 opened on Feb 25, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugConcept-Diagnostic ClarityFeature Requesthelp wanted

Description

For instance, see PublicSignWithRelativeKeyPath in CompilationAPITests.vb.

There are two errors:

BC2014: the value 'test.snk' is invalid for option 'CryptoKeyFile'
+BC37254: Public sign was specified and requires a public key, but no public key was specified

In this case, only the first error is really necessary. This is true for almost any set of incompatible crypto options with public sign, including using CryptoKeyContainer or any set of mutually incompatible options.

See https://github.com/dotnet/roslyn/pull/9130 for the full set of diagnostics produced by incompatible options.

Contributor guide

Tech stack
csharp
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicscompiler diagnostics understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the test `PublicSignWithRelativeKeyPath` in `CompilationAPITests.vb` to understand the current cascading behavior. Look at the diagnostics produced by incompatible crypto options as listed in PR #9130. The goal is to suppress the secondary error (BC37254) when the primary error (BC2014) is already reported. Changes will likely involve the diagnostic reporting logic for crypto options in the VB compiler.