dotnet/roslyn

InvalidOperationException while adjusting receiver namespace

Open

#8,610 opened on Feb 11, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

Microsoft.CodeAnalysis.VisualBasic.Symbols.NamespaceSymbol Shrink(System.Collections.Generic.IEnumerable`1[Microsoft.CodeAnalysis.VisualBasic.Symbols.NamespaceSymbol])
Microsoft.CodeAnalysis.VisualBasic.BoundNamespaceExpression AdjustReceiverNamespace(Microsoft.CodeAnalysis.VisualBasic.BoundNamespaceExpression, Microsoft.CodeAnalysis.ArrayBuilder`1[Microsoft.CodeAnalysis.VisualBasic.Symbol])
Microsoft.CodeAnalysis.VisualBasic.BoundExpression BindNamespaceOrTypeOrExpressionSyntaxForSemanticModel(Microsoft.CodeAnalysis.VisualBasic.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.DiagnosticBag)
Microsoft.CodeAnalysis.VisualBasic.BoundNode Bind(Microsoft.CodeAnalysis.VisualBasic.Binder, Microsoft.CodeAnalysis.VisualBasic.VisualBasicSyntaxNode, Microsoft.CodeAnalysis.DiagnosticBag)
System.Collections.Immutable.ImmutableArray`1[Microsoft.CodeAnalysis.VisualBasic.BoundNode] GetBoundNodes(Microsoft.CodeAnalysis.VisualBasic.VisualBasicSyntaxNode)
Microsoft.CodeAnalysis.VisualBasic.BoundNode GetUpperBoundNode(Microso...

The stack isn't great since it comes from telemetry. It should be better in Dev14U2.

~12K hits in 10 days.

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of .NET compiler internalsKnowledge of Visual Basic bindingFamiliarity with Roslyn source codeDebugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue reports an InvalidOperationException during namespace adjustment in the Visual Basic binder. The stack trace points to the Shrink and AdjustReceiverNamespace methods in the Visual Basic Symbols namespace. To fix this, one should first find a minimal reproducer, possibly by examining the telemetry context or creating a code sample that triggers the crash. Then, investigate the BindNamespaceOrTypeOrExpressionSyntaxForSemanticModel method and the subsequent calls to understand the invalid state. The high crash count (12K hits) suggests a common scenario, so focusing on common VB files with complex namespace structures may help. Consider adding an assertion or null check in the Shrink method to handle the invalid operation gracefully.