dotnet/roslyn

Rename doesn't resolve conflict via callsite cast

Open

#8,296 opened on Feb 2, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEFeature - Renamehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

interface IX
{
    void M(); 
} 
interface IY : IX
{
    int A(); 
} 

class C
{
    void Foo()
    {
        IY y = null; 
        y.M();
    }
}

Rename A to M.

Roslyn will show an unresolvable conflict, instead of casting the callsite to IX to call the base method.

Contributor guide

Research direction
Investigate how Roslyn's rename engine handles conflict resolution when renaming a method that hides a base interface method. Look for where the conflict is detected and see if a cast to the base interface can be applied at the callsite.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20