dotnet/roslyn

Improve error message when accessing globals within a class in a C# script

Open

#7,758 opened on Jan 3, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-InteractiveInteractive-ScriptingLogichelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Having Globals defined as

public class Globals
{
    public int X;
    public int Y;
}

the following works as expected

Console.WriteLine(CSharpScript.EvaluateAsync<int>(
    "X + Y",
    globals: new Globals { X = 1, Y = 2 }).Result);

while the following

Console.WriteLine(CSharpScript.EvaluateAsync<int>(
    @"class Foo
    {
        public int Bar()
        {
            return X + Y;
        }
    }

    var foo = new Foo();
    foo.Bar()", globals: new Globals { X = 1, Y = 2 }).Result);

fails with exception

Microsoft.CodeAnalysis.Scripting.CompilationErrorException: (5,24): error CS0120: An object reference is required for the non-static field, method, or property 'Globals.Y'

Expected behavior: The second sample executes successfully and returns (int)3.

Contributor guide

Research direction
Investigate how globals are resolved in C# scripts when a class is defined. The error indicates that globals are not accessible from within methods of a user defined class. Explore the script execution context and how global variables are bound. Look for existing tests or discussions about this behavior.
Tech stack
csharp
Domain
apideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Scripting API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70