dotnet/roslyn

Bug with ref properties and IDE0052

Open

#72,884 opened on Apr 5, 2024

View on GitHub
 (0 comments) (1 reaction) (1 assignee)C# (4,257 forks)batch import
Area-IDEBugFeature - IDE0052help wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: VS 17.9.0 on .NET 8.0

Steps to Reproduce:

class C1
{
	int a;
	private ref int A => ref a;
	public void Increment() => A++;
}

Diagnostic Id: IDE0052

Expected Behavior:

No diagnostic, since it's read, incremented, then written.

Actual Behavior:

There is a diagnostic claiming it's never been read.

Related:

Potentially https://github.com/dotnet/roslyn/issues/25057

Contributor guide

Research direction
Investigate the IDE0052 analyzer logic to see how it tracks reads and writes for ref properties. The false positive occurs because the analyzer may not recognize that incrementing via a ref property involves both a read and a write. Look at the handling of ref return values in the symbol usage analysis.
Tech stack
csharp
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50