dotnet/roslyn

Delegates are not properly reformatted when converting property from expression body to block body

Open

#71,637 opened on Jan 14, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: VS 17.8.4

Steps to Reproduce:

For both properties, open the lightbulb menu and select "Use block body for property".

class C
{
    Action A => delegate
    {
    };

    Action A2 => () =>
    {
    };
}

Expected Behavior: The block of the delegate or lambda is correctly indented. image

Actual Behavior: The indentation of the delegate body is not changed.

Interestingly, type creation expression within the property body are correctly formatted/indented: image

Contributor guide

Research direction
Investigate the C# formatting engine in Roslyn, specifically the code that handles converting expression bodied members to block bodied members. Look for where the indentation of delegate or lambda bodies is not being updated. Check the `SimplifyLambdaExpression` or `ConvertToBlockBody` related code.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50