dotnet/roslyn

Block syntax in expression-bodied method is not reformatted when refactoring implicitly converts it to block-bodied method

Open

#71,636 opened on Jan 14, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: VS 17.8.4

Steps to Reproduce:

For both methods, open the lightbulb menu on the parameter s and select "Add null check" (or any other refactoring that implicitly converts it to a block body).

class C
{
    int M(int v, string s) => v switch
    {
        _ => 0
    };

    object M(string s) => new
    {
        Id = 1
    };
}

Expected Behavior: The block syntax is reformatted and has the correct indentation, just like it is when selecting the "Use block body for method" refactoring. image

Actual Behavior: The block syntax is not reformatted and has the old and wrong indentation as a result. image

Contributor guide

Research direction
Examine the formatting logic in Roslyn that handles conversion of expression bodied methods to block bodied methods during refactoring. Focus on how indentation and block syntax are applied. Look at the 'Add null check' refactoring and the 'Use block body for method' refactoring to compare formatting behaviors.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60