dotnet/roslyn

Invert if refactoring is not available at the top-level

Open

#71,424 opened on Dec 30, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 4.8.0-7.23558.1 (e0917286)

Steps to Reproduce:

  1. Create a new console project. And replace Program.cs with the following 
    if (int.Parse("0") == 2)
{
    Console.WriteLine("Hello");
}
else
{
    Console.WriteLine("World");
}
  2. Put the text cursor at the beginning of if
  3. Open refactorings

Diagnostic Id: N/A

Expected Behavior: Invert if refactoring is applicable

Actual Behavior: Invert if is not present in refactorings

Contributor guide

Research direction
Investigate the 'Invert if' refactoring code in Roslyn, specifically the condition checks that determine when the refactoring is offered. Look for why it is not shown for top level if statements (like in Program.cs) and compare with how it works inside methods.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual Studio IDE refactoring concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70