dotnet/roslyn

Properties with inaccesible access methods shouldn't be visible

Open

#71,363 opened on Dec 19, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEIntelliSense-Completionhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Steps to Reproduce: Define property like

public Predicate<T>? Selector { protected get; init; }

or even without get method,

Expected Behavior: It shouldn't show by IDE in cases where you can't call these accessors.

Actual Behavior: This member is always visible.

Also, CA1044 diagnostic interpreted as warning by default looks bit annoying. I suggest to interpret it like suggestion by default.

Contributor guide

Research direction
Investigate how Roslyn's IDE layer determines property visibility in completion and find references. Look for the logic that checks accessor accessibility.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70