dotnet/roslyn

A code fix for CS8767 (nullability doesn't match) and friends would be awesome

Open

#70,535 opened on Oct 24, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

I'm enabling nullable anaylsis on a file, and getting warnings about the nullability not matching the implicitly implemented interface member:

It would be awesome if a code fix could update the declaration here, otherwise the only thing I have to go on is the tooltip, which keeps disappearing when I type. I imagine the same thing would be useful for members that override things, though at least in that case I could go-to-def on the override keyword and see the correct signature presumably.

Contributor guide

Research direction
Study existing code fixes for similar nullable warnings (e.g., CS8600, CS8618) to understand the pattern, then trace the analyzer for CS8767 (nullability mismatch) and implement a code fix that updates the declaration to match the interface member's nullability.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45