dotnet/roslyn

AbstractSuppressionCodeFixProvider replaces LF with CRLF

Open

#69,358 opened on Aug 3, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: Version 17.8.0 Preview 1.0 [33916.57.main]

Steps to Reproduce:

This issue tracks multiple disabled tests in code.

  1. Open a file with LF line endings in a project with end_of_line unset (Windows only) or explicitly set to CRLF
  2. Place the caret on a line with a diagnostic
  3. Suppress the diagnostic via the light bulb with a #pragma warning disable or #Disable Warning

Expected Behavior:

The file retains its LF line endings, including on the two newly inserted lines.

Actual Behavior:

The file has mixed line endings.

Contributor guide

Research direction
Find the disabled tests mentioned in the issue. Trace the code path of AbstractSuppressionCodeFixProvider when adding #pragma warning disable or #Disable Warning. Identify where newline characters are introduced and ensure they match the file's original line ending format.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git.NET SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60