dotnet/roslyn

Only Left and returnValue gets checked for dynamic in signature

Open

#69,215 opened on Jul 25, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

[jcouv:] the linked PR makes it clearer what the problem is. It just needs a test to verify the impact and fix.

Version Used: Main branch

Steps to Reproduce:

  1. I ran a roslyn analyser to check for identical subexpressions on this repo and encountered a diagnostic on this line.
  2. I checked to code if this was a correct diagnostic and to me it seemed like a correct diagnostic

Diagnostic Id: IdenticalSubexpression Expected Behavior: No diagnostic from an identical subexpression subexpression Actual Behavior:

I get a diagnostic from an identical subexpression subexpression on this line

Contributor guide

Research direction
Investigate the IdenticalSubexpression analyzer in the Roslyn codebase, particularly the logic that checks for dynamic expressions in signatures. Create a minimal reproduction test case that triggers the false positive, and then trace the code path to understand why the diagnostic is incorrectly emitted.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40