dotnet/roslyn

Refactor `CheckFeatureAvailability` to not accept a `Location` parameter

Open

#68,935 opened on Jul 8, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersArea-Performancehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Currently, CheckFeatureAvailability overloads take a Location parameter. Causing caller to call syntaxNode.Location which allocates a SourceLocation. At the end, if the feature is available, the allocation is thrown away.

Example:

https://github.com/dotnet/roslyn/blob/b203101cbc6672a9761a7ce4917d26be593aed26/src/Compilers/CSharp/Portable/Binder/Binder_Patterns.cs#L574

Not sure how much this pattern is hit, but it's good to optimize this anyway.

Contributor guide

Research direction
Find all overloads of CheckFeatureAvailability that take a Location parameter, analyze their callers to understand how to remove the parameter, and update the callers accordingly.
Tech stack
csharp
Domain
compilersbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70