dotnet/roslyn

Rename symbol misses symbol used in invalid assignment

Open

#67,665 opened on Apr 6, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEFeature - Renamehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: Version 17.7.0 Preview 1.0 [33604.490.main]

Steps to Reproduce:

class C
{
    private static readonly object _f;

    public C()
    {
        _f = new();
    }
}

Attempting to rename _f fails to rename the occurrence in the constructor. Admitted that occurrence is invalid (cannot assign to readonly static) but Go to definition and Find all references both resolve the usage, so rename should too.

My larger use case here was converting a field from local to static. I added static then had a diagnostic to update the name due to naming convention. It renamed the field to s_f but not the usage. Further investigation revealed the issue applies to manual renames too.

Contributor guide

Research direction
Investigate the rename logic in Roslyn, specifically how it resolves references in invalid assignments. The bug is that rename does not update the occurrence in the constructor when the field is readonly static. Check the code paths for rename and find all references to understand why the invalid assignment is not included.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55