dotnet/roslyn

WRN_ParamsArrayInLambdaOnly doesn't have single quotes around its argument.

Open

#66,389 opened on Jan 12, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersConcept-Diagnostic Clarityhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

  <data name="WRN_ParamsArrayInLambdaOnly" xml:space="preserve">
    <value>Parameter {0} has params modifier in lambda but not in target delegate type.</value>
  </data>

This is inconsistent with other diagnostics that we produce. Also the arguments blends in in the message. For example:

                // (67,49): warning CS9100: Parameter 1 has params modifier in lambda but not in target delegate type.
                //         Action<string[]> q17 = (params string[] s)=>{};
                Diagnostic(ErrorCode.WRN_ParamsArrayInLambdaOnly, "s").WithArguments("1").WithLocation(67, 49),

Another aspect to consider is, if we always use parameter number for the argument, then it might make sense to include the word "number" into the message. Number "1" could easily be confused with letter "l", for example, and interpreted as a name instead.

Contributor guide

Research direction
Locate the resource string 'WRN ParamsArrayInLambdaOnly' in the Roslyn repository and add single quotes around the '{0}' placeholder in the message. Ensure consistency with other similar diagnostic messages.
Tech stack
csharp
Domain
backendtoolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90