dotnet/roslyn

'Add argument name' refactoring works only at very beginning of attribute argument

Open

#63,365 opened on Aug 12, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-AnalyzersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Invoke lightbulb on the four locations indicated by $$

[My($$nu$$ll, null)]
class MyAttribute : System.Attribute
{
    public MyAttribute(string x, string y) { _ = new MyAttribute($$nu$$ll, null); }
}

Only 3 locations shows the refactoring. The one that doesn't work is invoking from middle of attribute argument.

Contributor guide

Research direction
Inspect the 'Add argument name' refactoring code path for attribute arguments to determine why it fails when invoked from the middle of an argument.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Visual Studio
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60