dotnet/roslyn

Change signature removes parameter I didn't select to be removed

Open

#62,824 opened on Jul 21, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Using https://github.com/dotnet/roslyn/commit/deabaa7744075fec2b2688872576561259761552

Go to https://github.com/dotnet/roslyn/blob/deabaa7744075fec2b2688872576561259761552/src/Analyzers/Core/Analyzers/AbstractBuiltInCodeStyleDiagnosticAnalyzer.cs#L72

Invoke "Change signature" and remove the unused language parameter. Note this strange change:

image

It also uses named arguments unnecessarily, but that's a minor point

image

Contributor guide

Research direction
Locate the Change Signature refactoring code in the Roslyn repository, specifically the method that handles parameter removal. Trace the logic to understand why it also removes a parameter that was not selected. Look at the test cases for Change Signature to reproduce the issue.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60