dotnet/roslyn

Investigate a niche 'required' scenario where the compiler overrides a property from IL

Open

#62,426 opened on Jul 6, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugFeature - Required Membershelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

So here is the scenario:

  • Define a Derived record that implements a Base record.
    • Base will be just record Base;
    • Derived will be written in IL where EqualityContract is marked required (add setter to EqualityContract in IL if necessary)
  • In C#, define a regular record that inherits Derived, ie, record R3 : Derived;
  • Will it compile successfully? It probably shouldn't?

I messaged @333fred about this scenario, and we both agree it's not an important one, but can probably have a bug.

Contributor guide

Research direction
Reproduce the scenario by creating an IL record with required EqualityContract and a derived C# record. Check if the compiler incorrectly overrides the property.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#IL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30