dotnet/roslyn

'Convert to raw string without leading whitespace' erroneously strips trailing whitespace

Open

#62,376 opened on Jul 5, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 17.3.0-p2.0

This is not the semantics change described by the light bulb fix.

var whereClause = "Age >= 18";

var x = @"
    select FirstName, LastName
    from dbo.People
    where " + whereClause;

💡 "Convert to raw string without leading whitespace (may change semantics)":

var whereClause = "Age >= 18";

var x = """
    select FirstName, LastName
    from dbo.People
    where
    """ + whereClause;

The resulting string contains whereAge >= 18 instead of where Age >= 18.

Contributor guide

Research direction
Inspect the code fix provider for 'Convert to raw string without leading whitespace' and trace the logic that computes the content of the raw string. Identify where the trailing whitespace is incorrectly removed and ensure the whitespace that is part of the original string is preserved.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75