dotnet/roslyn

Make ChangeSignature command handler asynchronous and avoid expensive semantic operations on UI thread

Open

#62,135 opened on Jun 24, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEConcept-Continuous Improvementhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

https://github.com/dotnet/roslyn/blob/f7634f7503665406e717d27bbac581b13a0c21b6/src/EditorFeatures/Core/ChangeSignature/AbstractChangeSignatureCommandHandler.cs#L89

https://github.com/dotnet/roslyn/blob/f7634f7503665406e717d27bbac581b13a0c21b6/src/EditorFeatures/Core/ChangeSignature/AbstractChangeSignatureCommandHandler.cs#L95

https://github.com/dotnet/roslyn/blob/f7634f7503665406e717d27bbac581b13a0c21b6/src/VisualStudio/Core/Def/ChangeSignature/AddParameterDialogViewModel.cs#L29

Contributor guide

Research direction
Inspect the linked code files to understand the current synchronous ChangeSignature command handler. Trace the call path to identify expensive semantic operations executed on the UI thread. Propose an async implementation using Task based async pattern with proper cancellation support.
Tech stack
csharp
Domain
developer experience
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Async Programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65