dotnet/roslyn

EditorConfig UI shouldn't include roaming-only code-style options

Open

#61,860 opened on Jun 13, 2022

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C# (4,257 forks)batch import
Area-IDEFeature - Editor Config UIhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

All code-style options in EditorConfig UI should have editorconfig storage location. For example, the following shouldn't exist:

https://github.com/dotnet/roslyn/blob/eee6b3c9180c77f4d58be0b2f8cafd2204297d10/src/VisualStudio/Core/Def/EditorConfigSettings/DataProvider/CodeStyle/CommonCodeStyleSettingsProvider.cs#L135-L138

We need a way to ensure this doesn't happen again. So the fix isn't simply to delete the above line. We also want to ensure that all the options are up to date.

Contributor guide

Research direction
Review the linked file CommonCodeStyleSettingsProvider.cs to identify options without EditorConfig storage. Then design a validation mechanism to ensure all future code style options have EditorConfig storage. Update the code accordingly and add tests.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70