dotnet/roslyn

Move Static Members to another type overwrites existing file and code

Open

#61,471 opened on May 23, 2022

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBugFeature - Move Static Membershelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

This issue has been moved from a ticket on Developer Community.

hello again :)

I've been developing a few related methods and had them all in one static class file, but then I wanted to refactor them out into their own files.

I had previously done this for a common method so there already existed a file with the standard name given by vs. In this case LayoutHelpers.cs

Anyway this had slipped my mind and in the previous (non preview version) I was used to VS behaving itself and checking if the file already existed.

I have come to rely on this magical refactoring tool and have not had issues before.

Anyway this time the original contents of the file were overwritten.

Hoping to be helpful I have recreated my steps and recorded the issue.

All the best

rob

image

Original Comments

Feedback Bot on 5/22/2022, 07:39 PM:

(private comment, text removed)

Feedback Bot on 5/23/2022, 00:23 PM:

(private comment, text removed)

Original Solutions

(no solutions)

Contributor guide

Research direction
Locate the MoveStaticMembers refactoring code in Roslyn and examine the file overwrite logic. Identify where it fails to check for existing files before writing.
Tech stack
csharp
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual StudioGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70