dotnet/roslyn

Issue with "Avoid expression statements that implicitly ignore value" code style fixer

Open

#61,467 opened on May 23, 2022

View on GitHub
 (5 comments) (5 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

This issue has been moved from a ticket on Developer Community.

The Avoid expression statements that implicitly ignore value code style setting can be set to Unused local or Discard:

image

However, I think that these settings do not cover all the scenarios, because there are cases in which we simply want to ignore the return values. I have attached a recording to show such a situation, that is also available at https://www.youtube.com/watch?v=ZuSf84-Mw44.

Original Comments

Feedback Bot on 5/22/2022, 07:54 PM:

(private comment, text removed)

Original Solutions

(no solutions)

Contributor guide

Research direction
Inspect the existing code fixer for 'Avoid expression statements that implicitly ignore value' in the Roslyn repo (likely in src/Features/Core/Portable/CodeStyle). Identify where the fixer currently handles ' ' discard and 'Unused' local scenarios. Then design a new option or extend the logic to allow ignoring return values more broadly, e.g., when the expression has no side effects. Test with the provided video scenario.
Tech stack
csharp
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60