dotnet/roslyn

Completion treats `:` as a commit character when providing a name in a tuple pattern

Open

#61,170 opened on May 7, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEIDE-IntelliSenseIntelliSense-Completionhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 17.2p6

Steps to Reproduce:

var test = (a: 1, b: 2, c: 3);

switch (test)
{
    case ($$ 1, 2, 3):
        break;
}

At the $$ location, type a:.

Expected Behavior:

The : isn't treated as a commit character, and a: is left alone.

Actual Behavior:

args: is inserted, as : is treated as a commit character and the highlighted completion is inserted.

Contributor guide

Research direction
Look at the commit character handling in completion for tuple pattern contexts. Investigate how `:` is being treated as a commit character and why the completion is inserting `args:` instead of leaving the typed text. Check the relevant source files in the Roslyn IDE layer, such as `CompletionProvider` or `CommitManager`.
Tech stack
csharp
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual Studio or Roslyn familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60