dotnet/roslyn

Use Site Diagnostics are missed in tuple symbols in VB

Open

#61,112 opened on May 3, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

https://github.com/dotnet/roslyn/blob/main/src/Compilers/VisualBasic/Portable/Symbols/Tuples/TupleEventSymbol.vb#L87 https://github.com/dotnet/roslyn/blob/main/src/Compilers/VisualBasic/Portable/Symbols/Tuples/TupleFieldSymbol.vb#L102 https://github.com/dotnet/roslyn/blob/main/src/Compilers/VisualBasic/Portable/Symbols/Tuples/TupleMethodSymbol.vb#L133 https://github.com/dotnet/roslyn/blob/main/src/Compilers/VisualBasic/Portable/Symbols/Tuples/TuplePropertySymbol.vb#L115

All of these call MergeUseSiteInfo and discard the result. In the VB compiler, that method does not take use site info by ref, it returns a new copy, so all of these locations will miss any use site info that should be reported.

Contributor guide

Research direction
Examine the four VB tuple symbol files and ensure that the result of MergeUseSiteInfo is stored or propagated appropriately instead of being discarded.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual Basic compiler internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40