dotnet/roslyn

Move static members to another type does not use the correct visibility

Open

#58,502 opened on Dec 27, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Related to https://github.com/dotnet/roslyn/issues/55127

Version Used: Version 17.1.0 Preview 1.1

Steps to Reproduce:

  1. Create a new class library, paste the following code in:
class Test
{
    private const string TestConstant = "";

    void M()
    {
        _ = TestConstant;
    }
}
  1. Ctrl+. on TestConstant, select "Move static members to another type..."
  2. Hit enter to accept the refactoring

Expected Behavior:

Generated code visibility allows for Test to see the constant.

Actual Behavior:

The following code is generated:

internal static class TestHelpers
{
    private const string TestConstant = "";
}

The constant is private, and compilation errors result as the original location cannot see the moved constant.

Contributor guide

Research direction
Investigate the MoveStaticMembers refactoring in the Roslyn codebase. Locate where the visibility of the generated members is determined and ensure it respects the access requirements of the original type.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60