dotnet/roslyn

Code Cleanup: Fixer to sort fields,props, methods etc. based on preferred order

Open

#58,215 opened on Dec 9, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEConcept-Continuous ImprovementDeveloper Communityhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

This issue has been moved from a ticket on Developer Community.

"csharp_preferred_modifier_order" with the fixer "Sort accessibility modifiers" only sort the modifiers itself.

There should also be a fixer to sort field, properties, method etc. based on a preferred order.

Original Comments

Feedback Bot on 11/25/2021, 08:33 PM:

Thank you for taking the time to provide your suggestion. We will do some preliminary checks to make sure we can proceed further. We'll provide an update once the issue has been triaged by the product team.

Contributor guide

Research direction
Investigate existing code fixers in Roslyn, specifically the 'Sort accessibility modifiers' fixer (CSharpPreferredModifierOrderFixer), and understand how to implement a new code fix for sorting members (fields, properties, methods, etc.) in a preferred order within a type declaration. Look at the analyzer/fixer infrastructure and the CodeFixProvider pattern.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60