dotnet/roslyn

Naming Style using underscore multiplies underscore

Open

#57,896 opened on Nov 20, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugDeveloper Communityhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work] [regression] Hi, I prefer "snake case" for my parameter and private field style in C#, and in setting up VS 2022 to prefer it, there was some unexpected behavior.

  • in C# section of text editor options.
  • I added a Naming Style specifying the Word Separator as underscore "" and Required prefix also had an underscore "".
  • I had a constructor with a parameter that had an underscore in the name i.e. "my_parameter"
  • using the Quick Actions and Refactor menu, I clicked create and assign field.

I expected the field to be named _my_parameter

the field was named _my___parameter with 3 underscores

I expected the single underscore to remain in the field name.

the my_parameter example is contrived to type this report.

I will attach the actual screenshots to this report.

Thank You

Jason Welty

B3d4da6a0e67f442eafc582db76088541637728520658533749_snake_case_bug_1 (1)

Bbd384935b970424f9af05747d2f55fc7637728520728812121_snake_case_bug_2

Original Comments

Feedback Bot on 11/18/2021, 07:02 PM:

Feedback Bot on 11/19/2021, 09:41 AM:

Original Solutions

(no solutions)

Contributor guide

Research direction
Investigate how the naming style rule for underscore prefix and word separator interacts when generating a field from a parameter that already contains underscores. Examine the code generation logic in the Roslyn IDE features, specifically the 'create and assign field' refactoring, to identify the source of the double underscore.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual Studio
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80