dotnet/roslyn

IDE0040 'Accessibility modifiers required' should be configurable to ignore partial containing classes

Open

#52,904 opened on Apr 25, 2021

View on GitHub
 (12 comments) (9 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEConcept-Continuous ImprovementFeature - IDE0040help wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

I don't like duplicating the accessibility modifiers on the second file, but out of the box now, .NET 5 puts a suggestion annotation in the code and the error list to do so:

internal sealed partial class A // Or some other modifiers
{
    // ...
}

// ℹ IDE0040 Accessibility modifiers required
//            ↓
partial class A
{
    private sealed class B
    {
        // ...
    }
}

Could IDE0040 please skip analyzing classes that are only specifying the minimal amount necessary to declare the nested type? If not, could this be made configurable?

Contributor guide

Research direction
Examine the IDE0040 analyzer implementation in dotnet/roslyn, locate where it reports on partial classes, and modify it to skip partial classes that match a containing partial class or add a configuration option to ignore such cases.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn analyzer development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60