dotnet/roslyn

VB auto-format should add original text to undo stack when auto-formatting copy-pasted text

Open

#51,042 opened on Feb 6, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugLanguage-VBhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used:

Steps to Reproduce:

  1. Copy the following multi-line text:
partial method that does not have implementation part is not emitted to metadata.
partial method that does not have implementation part is not emitted to metadata.
  1. Paste it to VB source file.
Module Program
    Sub Main(args As String())
      $$ 
    End Sub
End Module
  1. Ctrl+Z

Expected Behavior:

After copying (the first line is auto-formatted):

Module Program
    Sub Main(args As String())
      Partial method that does Not have implementation part Is Not emitted To metadata.
Partial method that does Not have implementation part Is Not emitted To metadata.
    End Sub
End Module

Ctrl+Z undoes the formatting,

Module Program
    Sub Main(args As String())
      partial method that does not have implementation part is not emitted to metadata.
partial method that does not have implementation part is not emitted to metadata.
    End Sub
End Module

Actual Behavior:

Cltr+Z removes the pasted text.

Contributor guide

Research direction
Investigate the VB auto format feature and its interaction with the undo stack. Look at how pasted text is formatted and how undo operations are recorded. Trace the code path from paste to format and then to undo. Use the Roslyn editor feature tests to reproduce the issue.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65