dotnet/roslyn

Analyzer renaming method name ignores operand of method address expression

Open

#50,077 opened on Dec 19, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBugFeature - RenameIDE-CodeStylehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: Visual Studio 16.8.2

Steps to Reproduce:

  1. In any C# source file, type:
    class A
    {
        private unsafe static void M1()
        {
            var xx = (delegate*<void>)(&M1);
        }
    }
  1. Change the name of M1 to M2 and use the "Rename 'M1' to 'M2'" refactoring action in VS.

Expected Behavior:

The expression in the initializer of xx changed to (delegate*<void>)(&M2).

Actual Behavior:

The expression in the initializer of xx remain unchanged as (delegate*<void>)(&M1).

Contributor guide

Research direction
Investigate the rename analyzer logic for method address expressions (&M1) and ensure it updates the operand.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70