dotnet/roslyn

CodeLens does not invalidate for changes in downstream projects

Open

#49,775 opened on Dec 3, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugCodeLenshelp wanted

Description

Version Used: e9fd4dc7

Steps to Reproduce:

  1. Create project A:

    public static class First {
  public static void Method() { }
}

  2. Create project B, which references project A:

    public class Second {
  public void Method() {
    First.Method();
  }
}

  3. Observe the CodeLens reference count on First.Method

  4. Comment out Second.Method

  5. Observe the CodeLens reference count on First.Method

Expected Behavior:

  • At step (3), the reference count is 1
  • At step (5), the reference count is 0

Actual Behavior:

  • ✔ At step (3), the reference count is 1
  • ❌ At step (5), the reference count is 1

Additional Details:

The change in step (4) does not update the project version which is used here for data point invalidation:

https://github.com/dotnet/roslyn/blob/6eecbdbeff1a547709b53f5bdc93b60749c6b1ef/src/VisualStudio/Core/Def/Implementation/CodeLens/CodeLensCallbackListener.cs#L70

Contributor guide

Tech stack
csharp
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn CodeLens architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the project version invalidation mechanism in CodeLensCallbackListener.cs, specifically line 70. Understand why changes in downstream projects do not update the project version. Check if the project version is only computed for top level projects and consider extending it to include downstream references. Look for any tests related to CodeLens invalidation and ensure the fix handles multi project solutions.