dotnet/roslyn

Allow diagnosticsuppressors to be configured in .editorconfig

Open

#49,727 opened on Dec 2, 2020

View on GitHub
 (4 comments) (4 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-AnalyzersBugFeature - Editor Confighelp wanted

Description

The only way a DiagnosticsSuppressor can be disabled is now using a separate ruleset. Rulesets were replaced with .editorconfig for all but suppressors.

Can the code at AnalyzerManager.IsDiagnosticAnalyzerSuppressed be updated to (also) look at the .editorconfig?

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of .NET compiler internalsUnderstanding of .editorconfig
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue requests extending DiagnosticsSuppressor configuration to .editorconfig. Start by examining the referenced file `AnalyzerManager.cs` at the `IsDiagnosticAnalyzerSuppressed` method (line 356-365). Investigate how other diagnostic settings are read from .editorconfig to replicate the pattern. Check existing tests for similar features to understand expected behavior and integration points.