dotnet/roslyn

CSharpUpgradeProjectCodeFixProvider sometimes reports the wrong version

Open

#48,548 opened on Oct 13, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugIDE-CodeStyleIntegration-Testhelp wanted

Description

Version Used: Periodically appearing in integration tests, e.g. #48372

Steps to Reproduce:

Run the LegacyProject_AllConfigurationsUpdated test.

Expected Behavior:

Upgrade this project to C# language version '7.3'

Actual Behavior:

Upgrade this project to C# language version 'default'

image

Build Kind Start Time
869712 PR 48895 2020-29-10

Contributor guide

Tech stack
csharp
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# knowledgeUnderstanding of Roslyn code fix providers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the `CSharpUpgradeProjectCodeFixProvider` class and its version detection logic. Reproduce the failure using the `LegacyProject AllConfigurationsUpdated` test. Investigate the linked PR #48895 for context on the expected version '7.3' vs the actual 'default'. Look for recent changes or comments that may indicate the root cause.