dotnet/roslyn

Override Equals in subtypes of DiagnosticInfo

Open

#4,786 opened on Aug 25, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugConcept-Continuous Improvementhelp wanted

Description

For example, DiagnosticInfoWithSymbols introduces a Symbols field that is not considered by DiagnosticInfo.Equals.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#object oriented programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the DiagnosticInfoWithSymbols class in the Roslyn codebase (likely in src/Compilers/Core/Portable/Diagnostic/DiagnosticInfoWithSymbols.cs) and override the Equals method to include the Symbols field in the equality comparison. Follow the same pattern as the base DiagnosticInfo.Equals implementation.