dotnet/roslyn

Change signature does not handle errors at call sites well

Open

#46,456 opened on Jul 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBughelp wanted

Description

Version Used: Version 16.8.0 Preview 2.0 [30327.8.master]

Steps to Reproduce:

  1. Checkout Roslyn at a7976180954969c9904ee6d449adad28283ddc34
  2. Open src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.WorkItem.cs and find WorkItem constructor on line 95
  3. Remove bool isLowPriority parameter using Change signature refactoring.
  4. Notice isLowPairority argument is now squiggled as expected. image
  5. Without fixing the error, use Change signature refactoring to remove bool isLowPriority parameter from the constructor on line 100.
  6. Review changes: image

Notice invocationReasons and retry: false were removed.

Contributor guide

Tech stack
None
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn codebaseRefactoring APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Reproduce the issue using the steps in the description. Investigate the Change Signature refactoring implementation in the Roslyn codebase, likely in the Features project (e.g., ChangeSignatureCommand.cs). Examine how the refactoring handles error states during successive calls. Look at the file src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.WorkItem.cs to understand the context. Ensure that unrelated arguments are not removed when there are errors. Add tests for this scenario.