dotnet/roslyn

Change signature does not handle errors at call sites well

Open

#46,456 opened on Jul 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: Version 16.8.0 Preview 2.0 [30327.8.master]

Steps to Reproduce:

  1. Checkout Roslyn at a7976180954969c9904ee6d449adad28283ddc34
  2. Open src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.WorkItem.cs and find WorkItem constructor on line 95
  3. Remove bool isLowPriority parameter using Change signature refactoring.
  4. Notice isLowPairority argument is now squiggled as expected. image
  5. Without fixing the error, use Change signature refactoring to remove bool isLowPriority parameter from the constructor on line 100.
  6. Review changes: image

Notice invocationReasons and retry: false were removed.

Contributor guide

Research direction
Investigate the ChangeSignature refactoring code in Roslyn, focusing on how it handles call sites with existing errors. Trace the logic that enumerates arguments and identify why it removes 'invocationReasons' and 'retry: false' when an error is present.
Tech stack
csharp
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60