dotnet/roslyn

Change signature adds unnecessary argument names when removing a parameter

Open

#46,455 opened on Jul 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBughelp wanted

Description

Version Used: Version 16.8.0 Preview 2.0 [30327.8.master]

Steps to Reproduce:

  1. Checkout Roslyn at a7976180954969c9904ee6d449adad28283ddc34

  2. Open src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.WorkItem.cs and find WorkItem constructor on line 95

  3. Remove bool isLowPriority parameter.

  4. Review changes.

src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.SemanticChangeProcessor.cs:

image

src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.cs:

image

Contributor guide

Tech stack
csharp
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C#familiarity with Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the Change Signature refactoring logic to understand why removing a parameter adds unnecessary argument names. Look at files like `WorkCoordinator.SemanticChangeProcessor.cs` and `WorkCoordinator.cs` in `src/Features/Core/Portable/SolutionCrawler/`. Check the generated code for the parameter removal case and identify where the argument names are incorrectly added.
Change signature adds unnecessary argument names when removing a parameter · dotnet/roslyn#46455 | Good First Issue