dotnet/roslyn

CSharpDecompiledSourceService doesn't support nested types

Open

#46,076 opened on Jul 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBughelp wanted

Description

Version Used: 16.6.3

Steps to Reproduce: Reference a nested type from a .dll and try to decompile it

InvalidOperationException: Could not find type definition A.NestedClass in type system.

  | CSharpDecompiler.DecompileType Line 817
-- | --
  | CSharpDecompiler.DecompileTypeAsString Line 840
  | CSharpDecompiledSourceService.PerformDecompilation Line 115
  | CSharpDecompiledSourceService.<AddSourceToAsync>d__3.MoveNext Line 74

This method should append the names of parent types (and probably use the + separator?) https://github.com/dotnet/roslyn/blob/8bedf286254d901c48f2cfd562cf3425de2b2e10/src/EditorFeatures/CSharp/DecompiledSource/CSharpDecompiledSourceService.cs#L160-L175

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsfamiliarity with decompilation concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the method `PerformDecompilation` in `CSharpDecompiledSourceService.cs` around line 160-175. The issue states that the method does not handle nested types, causing an `InvalidOperationException` when trying to decompile a nested type from a DLL. The suggested fix is to append parent type names using the '+' separator. Look at how type names are resolved in the `DecompileType` and `DecompileTypeAsString` methods to understand the current logic and implement the necessary changes to support nested types.
CSharpDecompiledSourceService doesn't support nested types · dotnet/roslyn#46076 | Good First Issue