dotnet/roslyn

IDE0059 (unnecessary assignment to a value) false positive for VB catch statement

Open

#45,896 opened on Jul 10, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugFeature - IDE0059IDE-CodeStylehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

See https://github.com/dotnet/roslyn/pull/45847/commits/c54743b71f398738408cbb4be860ab1a53d8e7cc#diff-aeaeb48464894aa3843d1bda663ad7fbR98

e1 is flagged with IDE0059, but there is no way to remove it: https://github.com/dotnet/roslyn/blob/e5a8db4ff486983f531ab56adc585c191cf95885/src/EditorFeatures/VisualBasicTest/EditAndContinue/VisualBasicEditAndContinueAnalyzerTests.vb#L91-L110

Contributor guide

Research direction
Investigate the IDE0059 analyzer's handling of Catch block variables in VB.NET. Examine the code path where the analyzer flags the exception variable 'e1' as unnecessary assignment. Determine if there are any existing tests or code that handle this case incorrectly.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Visual BasicRoslyn analyzer basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60