dotnet/roslyn

IDE0060 false positive for method used as a delegate in nested type

Open

#44,226 opened on May 13, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugFeature - IDE0060IDE-CodeStylehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

See https://github.com/dotnet/roslyn/pull/44199/files#diff-346d613909e7c03e101f681834c8e015R22 in VisualBasicEscapingReducer.vb

#Disable Warning IDE0060 ' Remove unused parameter - False positive, used as a delegate in a nested type.
        ' TODO: File a bug for this 'IDE0060' false positive.
        Private Shared Function TryUnescapeToken(identifier As SyntaxToken, semanticModel As SemanticModel, optionSet As OptionSet, cancellationToken As CancellationToken) As SyntaxToken
#Enable Warning IDE0060 ' Remove unused parameter
            If Not identifier.IsBracketed Then
                Return identifier
            End If

Contributor guide

Research direction
Inspect the code at the referenced line in VisualBasicEscapingReducer.vb and identify why IDE0060 is falsely triggered for the TryUnescapeToken delegate. Investigate the handling of nested type delegates in the IDE0060 analyzer.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35