dotnet/roslyn

Remove unneccessary instructions from variable-less filter

Open

#4,388 opened on Aug 6, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersConcept-Continuous ImprovementFeature Requesthelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

When an exception filter doesn’t specify the exception variable, for example:

            try   {   …   }  catch when (F())  {  …   }

we emit

filter
  {
    IL_0006:  isinst     [mscorlib]System.Object
    IL_000b:  dup
    IL_000c:  brtrue.s   IL_0012
    IL_000e:  pop
    IL_000f:  ldc.i4.0
    IL_0010:  br.s       IL_001b
    IL_0012:  pop
    IL_0013:  call       bool ConsoleApplication1.Program::F()
    IL_0018:  ldc.i4.0
    IL_0019:  cgt.un
    IL_001b:  endfilter
  }  // end filter

The Object type check is unnecessary. The following IL sequence is verifiable and works equally well imo:

filter
  {
    IL_0012:  pop
    IL_0013:  call       bool ConsoleApplication1.Program::F()
    IL_0018:  ldc.i4.0
    IL_0019:  cgt.un
    IL_001b:  endfilter
  }  // end filter

Avoiding implicit reference to System.Object would simplify some low-level .NET Native scenarios that are layered below CoreFX and thus can't have a dependency on System.Object.

Contributor guide

Research direction
Examine the IL generation code for exception filter clauses in the Roslyn compiler (likely in the Microsoft.CodeAnalysis.CSharp or Microsoft.CodeAnalysis.VisualBasic project). Find where the isinst instruction is emitted for the filter block and conditionally skip it when no exception variable is specified.
Tech stack
csharp
Domain
backendcompilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#ILRoslyn codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30