dotnet/roslyn

Pressing SHIFT+ENTER in Intermediate window results in a fault

Open

#42,784 opened on Mar 26, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-InteractiveBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used:

Steps to Reproduce:

  1. While debugging, open Intermediate window, type Console.WriteLine and press ENTER
  2. Press UP arrow
  3. Press SHIFT+ENTER
System.NotSupportedException: Changing documents is not supported.   
at Microsoft.CodeAnalysis.Workspace.CheckAllowedProjectChanges(ProjectChanges projectChanges)   
at Microsoft.CodeAnalysis.Workspace.CheckAllowedSolutionChanges(SolutionChanges solutionChanges)  
at Microsoft.CodeAnalysis.Workspace.TryApplyChanges(Solution newSolution, IProgressTracker progressTracker)   
at Microsoft.CodeAnalysis.Workspace.TryApplyChanges(Solution newSolution)   
at Microsoft.CodeAnalysis.Editor.Implementation.AutomaticCompletion.Extensions.ApplyTextChanges(Document document, IEnumerable`1 textChanges, CancellationToken cancellationToken)   
at Microsoft.CodeAnalysis.Editor.CSharp.AutomaticCompletion.AutomaticLineEnderCommandHandler.FormatAndApply(Document document, Int32 position, CancellationToken cancellationToken)   
at Microsoft.CodeAnalysis.Editor.Implementation.AutomaticCompletion.AbstractAutomaticLineEnderCommandHandler.ExecuteCommand(AutomaticLineEnderCommandArgs args, Action nextHandler, CommandExecutionContext context)   
at Microsoft.VisualStudio.Commanding.CommandHandlerExtensions.ExecuteCommand[T](ICommandHandler commandHandler, T args, Action nextCommandHandler, CommandExecutionContext executionContext)   
at Microsoft.VisualStudio.UI.Text.Commanding.Implementation.EditorCommandHandlerService.<>c__DisplayClass13_1`1.<Execute>b__1()   
at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.CallExtensionPoint(Object errorSource, Action call, Predicate`1 exceptionFilter)
--- End of stack trace from previous location where exception was thrown ---   
at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)</description>

Contributor guide

Research direction
Examine the AutomaticLineEnderCommandHandler to understand why it tries to apply changes that require project modifications when SHIFT+ENTER is used in the Intermediate window. Look for a guard clause that checks if workspace changes are allowed.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn editor APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60