dotnet/roslyn

Skip documents whose content failed to load from analysis

Open

#41,661 opened on Feb 13, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-AnalyzersConcept-Continuous Improvementhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Analyzers shouldn't be run on documents (syntax trees) with load failures. These should be treated as generated files (they are empty).

Follow up on https://github.com/dotnet/roslyn/pull/40815.

Contributor guide

Research direction
Examine the referenced PR #40815 to understand how document load failures are currently handled. Then trace the analyzer pipeline to ensure documents with failed loads are skipped.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60