dotnet/roslyn

Unskip unit test AddImportTests.TestAddImportWithCaseChange

Open

#41,484 opened on Feb 7, 2020

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Following unit test is attempting to validate that the CodeActionPriority of the offered code fix is Medium and not High. https://github.com/dotnet/roslyn/blob/aaed1133a5bc0db1387ae8538f0b648520d55241/src/EditorFeatures/VisualBasicTest/Diagnostics/AddImport/AddImportTests.vb#L78-L102

However, due to a bug in test framework, the validation is not even being performed. Attempting to fix the test framework in https://github.com/dotnet/roslyn/pull/41363 causes the unit test to fail as the offered code fix is indeed still at CodeActionPriority.High. I am going to skip the unit test as part of that PR, and use this issue to track fixing the product behavior and unskip the test.

Contributor guide

Research direction
Inspect the skipped test and the related test framework to understand why the validation is not performed. Then, investigate the code fix logic to find why it returns High priority instead of Medium.
Tech stack
csharp
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70