dotnet/roslyn

Find All References does not count usages from the Implicit Range support

Open

#41,310 opened on Jan 30, 2020

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-CompilersBlockedConcept-Continuous ImprovementFeature - RangeIDE-Navigationhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 16.4.3

Steps to Reproduce:

public class T
{
    public int Length => 42;
    public int Slice(int start, int length) => start + length;
    public static void M()
    {
        var t = new T();
        var o = t[0..^1];
    }
}

Run Find All References on Length or Slice or look at CodeLense

Expected Behavior: Both Length and Slice should have one reference from using the implicit range in M().

Actual Behavior: The implicit usage is not reported.

image

Contributor guide

Research direction
Investigate how Roslyn's Find All References handles implicit range expressions (e.g., t[0..^1]). Trace the semantic model to see if the implicit Slice and Length calls are being bound and if the reference search is missing them due to not expanding implicit constructs.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Roslyn
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50