dotnet/roslyn

Refactor/rename parameter in interface does not rename in implementations to satisfy CA1725

Open

#41,298 opened on Jan 30, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (4,257 forks)batch import
Area-IDEBugFeature - Renamehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

This issue has been moved from a ticket on Developer Community.

When I use the refactor|rename command for a parameter in an interface, any implementations that were using the same name are unchanged and therefore don't compile as I have the code analysis rule (CA1725) that requires the names to match turned on. The "refactor" command should never cause code not to compile surely!

Original Comments

Visual Studio Feedback System on 12/29/2019, 07:28 PM:

Visual Studio Feedback System on 12/30/2019, 10:04 AM:

Original Solutions

(no solutions)

Contributor guide

Research direction
Investigate the rename tracking logic for parameters in interfaces and their implementations. Focus on how the refactoring engine maps parameter symbols across interface and implementation methods.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Roslyn SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60