dotnet/roslyn

Extract method does not respect whitespace when extracting a return statement

Open

#40,023 opened on Nov 26, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugFeature - Extract Methodhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 16.4.0 P6

Steps to Reproduce:

  1. Highlight a single return statement
  2. Ctrl+. and select extract method code action

Expected Behavior: Newline above return statement preserved

Actual Behavior: Newline not preserved. Seems to be an edge case since extracting regular statements seems to correctly preserve the newline if present.

newlinenotrespected

Contributor guide

Research direction
Find the extract method code action in the Roslyn codebase and trace the logic for handling whitespace around return statements. Look for existing tests for extract method and add a failing test that reproduces the issue. Then fix the code to preserve whitespace.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60