dotnet/roslyn

Extract method does not respect whitespace when extracting a return statement

Open

#40,023 opened on Nov 26, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugFeature - Extract Methodhelp wanted

Description

Version Used: 16.4.0 P6

Steps to Reproduce:

  1. Highlight a single return statement
  2. Ctrl+. and select extract method code action

Expected Behavior: Newline above return statement preserved

Actual Behavior: Newline not preserved. Seems to be an edge case since extracting regular statements seems to correctly preserve the newline if present.

newlinenotrespected

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn syntax treescode refactoring concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the ExtractMethod refactoring in Roslyn (likely under src/Features/Core/Portable/ExtractMethod/). Look at how the method generates the extracted method and call site, particularly how it handles whitespace before return statements. The issue suggests that for regular statements newline is preserved but for return statements it's not. Check the logic that inserts trivia (whitespace) when constructing the new method body. You may need to trace the code flow from the code action invocation to the syntax generation step.