dotnet/roslyn

IDE0065 messes up if/endifs around namespaces

Open

#40,001 opened on Nov 25, 2019

View on GitHub
 (4 comments) (3 reactions) (2 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugFeature - IDE0065IDE-CodeStylehelp wanted

Description

Version Used: 3.5.0-beta2-19570-07+4bd316035f64c9776d5420af71df8ba38e8e23e4

Steps to Reproduce: Create a project with this code:

using System;

namespace MyNamespace
{
#if !FOO
    using System.Runtime.CompilerServices;
#endif

    class Program
    {
        static void Main() { }
    }
}

Then apply IDE0065 when it fires on the using System.Runtime.CompilerServices; directive.

Expected Behavior: Refactors to:

using System;
#if !FOO
using System.Runtime.CompilerServices;
#endif

namespace MyNamespace
{
    class Program
    {
        static void Main() { }
    }
}

or doesn't offer the refactoring.

Actual Behavior: Refactors to:

using System;
#if !FOO
using System.Runtime.CompilerServices;

namespace MyNamespace
{
#endif

    class Program
    {
        static void Main() { }
    }
}

which is broken and won't compile if that compilation constant is set.

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# language basicsunderstanding of preprocessor directivesfamiliarity with Roslyn analyzer structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Reproduce the issue locally using the provided code snippet. The bug is in the IDE0065 code fix provider, likely in the file that moves using directives outside namespaces. Examine how the code fix handles conditional compilation directives (#if). Consider whether the fix should be aborted or correctly move the entire block including the preprocessor directives. Check the existing tests for IDE0065 to understand expected behavior.