dotnet/roslyn

MoveTypeCodeRefactoringProvider doesn't work for linked code

Open

#39,733 opened on Nov 8, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugIDE-CodeStylehelp wanted

Description

My csproj file refers to a particular file via:

  <ItemGroup>
    <Compile Include="..\..\Some\Other\Place\**\*.cs" LinkBase="FooBar" />
  </ItemGroup>

But when I try to use the refactor command to move classes in these files into their own .cs files, it crashes and the stack trace indicates it couldn't find the new file in "FooBar" directory, which doesn't actually exist. v16.2.3

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C#Roslyn refactoringcsproj linked files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the MoveTypeCodeRefactoringProvider in the Roslyn codebase. Focus on how it resolves file paths when the file is included via a linked project item. The crash suggests it's trying to create a file in a 'FooBar' directory that doesn't exist. Possibly fix the path resolution to handle linked files correctly.