dotnet/roslyn

MoveTypeCodeRefactoringProvider doesn't work for linked code

Open

#39,733 opened on Nov 8, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugIDE-CodeStylehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

My csproj file refers to a particular file via:

  <ItemGroup>
    <Compile Include="..\..\Some\Other\Place\**\*.cs" LinkBase="FooBar" />
  </ItemGroup>

But when I try to use the refactor command to move classes in these files into their own .cs files, it crashes and the stack trace indicates it couldn't find the new file in "FooBar" directory, which doesn't actually exist. v16.2.3

Contributor guide

Research direction
Investigate the file path resolution logic in MoveTypeCodeRefactoringProvider when dealing with linked files using LinkBase in csproj files. Trace how the provider determines the output path and why it expects a non existent directory.
Tech stack
csharp
Domain
backenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#MSBuild
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50